Skip to content

setup protobuf versioning#71

Merged
wojcik91 merged 30 commits intodevfrom
protobuf_versioning
Apr 9, 2026
Merged

setup protobuf versioning#71
wojcik91 merged 30 commits intodevfrom
protobuf_versioning

Conversation

@wojcik91
Copy link
Copy Markdown
Contributor

@wojcik91 wojcik91 commented Mar 25, 2026

Introduce protobuf versioning before 2.0 release to avoid supporting deprecated 1.x functionalities.

Summary of changes:

  • split protos into v1 and v2 packages, so both legacy and latest versions can use the same repo
  • introduce a more standardized naming convention for packages
  • align enum variant naming with linter rules
  • add a dedicated client_types package so both v1 and v2 proxy supports existing desktop/mobile clients
  • clean up deprecated fields
  • fix field numbering for messages with removed fields
  • change latest_timestamp field in PeerStats message to actual Timestamp to not discard sub-second precision
  • add CI tests

v1 modules are supposed to be a snapshot of the main branch so legacy services can also be migrated to this version.

Related DefGuard/defguard#2414

PRs updating specific services:

@wojcik91 wojcik91 self-assigned this Mar 25, 2026
@wojcik91 wojcik91 marked this pull request as draft March 25, 2026 11:34
@wojcik91 wojcik91 marked this pull request as ready for review March 25, 2026 15:15
moubctez
moubctez previously approved these changes Mar 26, 2026
moubctez
moubctez previously approved these changes Mar 31, 2026
@wojcik91 wojcik91 merged commit 7adfe3b into dev Apr 9, 2026
1 check passed
@wojcik91 wojcik91 deleted the protobuf_versioning branch April 9, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants